Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Epiverse-TRACE lintr settings #67

Merged
merged 24 commits into from
Nov 23, 2023
Merged

Use Epiverse-TRACE lintr settings #67

merged 24 commits into from
Nov 23, 2023

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Oct 9, 2023

No description provided.

This was referenced Nov 23, 2023
Merged
Merged
GeraldineGomez
GeraldineGomez reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@GeraldineGomez GeraldineGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept changes, except for 'stringr::str_detect(file_name, ".xls")'

  • The available formats from SIVIGILA include '.xlsx' as well.

GeraldineGomez
GeraldineGomez reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@GeraldineGomez GeraldineGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was include in dev branch

@GeraldineGomez GeraldineGomez merged commit fc63caf into main Nov 23, 2023
8 checks passed
@GeraldineGomez GeraldineGomez deleted the lintr branch November 23, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeraldineGomez GeraldineGomez GeraldineGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bisaloo @GeraldineGomez